I have taken 5-6 grams of vitamin C every day for years. At first I thought it was a waste and it all sounds like crackhead talk when you listen to some of the vitamin C zealots. I have had periods where I went without it for years as well. But over the past 20 years I have consistently noted reduction in cold symptoms, improved stress tolerance, and just general good health. It may be placebo, chance, whatever - but it is $30/kg and I dump a scoop in a gallon of crystal light and drink it every day.
I will also say that a lot of the research throwing shade on Vitamin C has questionable conclusions- like the study that everyone quotes showing it did not reduce colds in the general population but DID in highly stressed military trainees and the conclusion is that it is worthless for the average person. So, um, it works when you really need it but does nothing otherwise?
It also has evidence of reduced infection - including its potential for being part of a treatment for sepsis that is currently being investigated.
But...I don't know. It may still have little value, a lot of it does sound like snake oil (and I am being serious), but I lean in its favor because of the track record it has for me personally, especially the increased incidence of colds when I am not taking it.